Enable User Agent feature extension#4124
Merged
cheenamalhotra merged 2 commits intomainfrom Apr 7, 2026
Merged
Conversation
cheenamalhotra
added
the
Hotfix Candidate 🚑
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the EnableUserAgent AppContext switch and makes the UserAgent TDS feature extension always included when feature extensions are requested, aligning the driver behavior with always-on UserAgent support.
Changes:
- Remove
LocalAppContextSwitches.EnableUserAgentand related test helper plumbing. - Always write the UserAgent feature extension request in
TdsParserwhenrequestedFeaturesincludesUserAgent. - Update simulated server unit tests to stop toggling the removed switch.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/Microsoft.Data.SqlClient/tests/UnitTests/SimulatedServerTests/ConnectionTests.cs | Removes per-test switch toggling for UserAgent feature extension. |
| src/Microsoft.Data.SqlClient/tests/UnitTests/Microsoft/Data/SqlClient/LocalAppContextSwitchesTest.cs | Drops the default-value assertion for the removed switch. |
| src/Microsoft.Data.SqlClient/tests/Common/LocalAppContextSwitchesHelper.cs | Removes reflection-based support for capturing/restoring the removed switch. |
| src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/TdsParser.cs | Removes the AppContext gate so UserAgent request is written whenever requested. |
| src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/LocalAppContextSwitches.cs | Deletes the EnableUserAgent switch definition, cache field, and accessor. |
src/Microsoft.Data.SqlClient/tests/UnitTests/SimulatedServerTests/ConnectionTests.cs
Outdated
Show resolved
Hide resolved
cheenamalhotra
added
Hotfix 7.0.1
Contributor
|
Is this info avaliable on the Azure SQL side and if so, how? |
paulmedynski
requested changes
Apr 1, 2026
src/Microsoft.Data.SqlClient/tests/UnitTests/SimulatedServerTests/ConnectionTests.cs
Outdated
Show resolved
Hide resolved
github-project-automation
bot
moved this from In review
to In progress
in SqlClient Board
paulmedynski
approved these changes
Apr 1, 2026
Contributor
@ErikEJ - AFAIK, this information is not visible external to Microsoft at the moment. |
mdaigle
approved these changes
Apr 6, 2026
paulmedynski
force-pushed
the
dev/cheena/enableuseragent
branch
from
1a1599b to
aebd3bd
Compare
src/Microsoft.Data.SqlClient/tests/UnitTests/SimulatedServerTests/ConnectionTests.cs
Show resolved
Hide resolved
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## main #4124 +/- ##
==========================================
- Coverage 73.22% 66.56% -6.66%
==========================================
Files 280 274 -6
Lines 43000 65796 +22796
==========================================
+ Hits 31486 43797 +12311
- Misses 11514 21999 +10485
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
paulmedynski
force-pushed
the
dev/cheena/enableuseragent
branch
from
aebd3bd to
cbe5a85
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes app context switch no longer needed - feature is to be always-enabled.